> On May 19, 2012, 9:59 a.m., Martin Klapetek wrote: > > x-messenger-oauth2-auth-operation.cpp, lines 127-128 > > <http://git.reviewboard.kde.org/r/104987/diff/1/?file=64845#file64845line127> > > > > Just for me to understand - both tokens are the same?
WTF! No! > On May 19, 2012, 9:59 a.m., Martin Klapetek wrote: > > x-messenger-oauth2-auth-operation.cpp, line 39 > > <http://git.reviewboard.kde.org/r/104987/diff/1/?file=64845#file64845line39> > > > > I'd suggest to keep that, it doesn't hurt and can help users updating > > from 0.3.x directly (Kubuntu 12.04 LTS) Ok, I'll replace it with "in a later version" ;) > On May 19, 2012, 9:59 a.m., Martin Klapetek wrote: > > x-messenger-oauth2-auth-operation.cpp, line 89 > > <http://git.reviewboard.kde.org/r/104987/diff/1/?file=64845#file64845line89> > > > > I know this is an old code but can this possibly output user's > > credentials? I don't think so, credential should not be in "reason" and/or in "details", if they are it is a bug upstream... - Daniele Elmo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104987/#review13967 ----------------------------------------------------------- On May 18, 2012, 8:56 p.m., Daniele Elmo Domenichelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104987/ > ----------------------------------------------------------- > > (Updated May 18, 2012, 8:56 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Retrieve and save refresh token for X-MESSENGER-OAUTH2 authentication. > The refresh token will be used (in the future) to gain the access token when > the old one is expired, so that the user can insert the password just the > first time that he logs in. > > The patch introduces the dependency on QJSON to parse the server reply, > renames the token stored in KWallet from token to access_token, and stores > the new refresh_token in kwallet. The authentication method is slightly > different and requires another call to the server. > > It's a bit late for 0.4, but I would like to ask for an exception, and to > merge this part of the patch, so that perhaps I can add the second part (that > will use the refresh token to get the new access token, and that I still need > to write) in 0.4.1, as it won't introduce big changes. Sorry, but I was very > busy recently... > > > Diffs > ----- > > CMakeLists.txt e6b1df7d1017483c8234c739f84c2cc81b339882 > cmake/modules/FindQJSON.cmake PRE-CREATION > x-messenger-oauth2-auth-operation.cpp > e4aa800faecb17d12c2524d6660eb9e871cb285f > x-messenger-oauth2-prompt.h c87d6e7ea14c017cefd2db48d1e256802331a7eb > x-messenger-oauth2-prompt.cpp c987ffdbde334c010a98478a28db740ae7bde049 > > Diff: http://git.reviewboard.kde.org/r/104987/diff/ > > > Testing > ------- > > access_token is retrieved and correctly used to log in, refresh_token is > saved. > > > Thanks, > > Daniele Elmo Domenichelli > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
