> On June 25, 2012, 11:48 a.m., Martin Klapetek wrote: > > First of all thanks for a perfect review request! That's how they all > > should be done ;) > > > > As for the change - I'm not in favor. Truth is that the bold font looks > > bad, but the italics looks a bit worse for my eyes. I'd like to do two > > things here - Nikita, please add Usability group in the review groups. To > > all others - try brainstorming some ideas here how we can separate these > > (do we need it at all?). > > Kai Uwe Broulik wrote: > As far as I can tell the custom presence messages still include a status > such as "Away" or "Busy"? > So we could add a custom delegate to the combobox to have it in two-rows. > A bigger icon on the left and the generic term as heading and if available a > custom subtitle below it. Similar to e.g. Plasma does for the Wallpaper > Plugin. > See here: http://privat.broulik.de/plasmacustomdelegate.png > I think in this example the bold font doesn’t look bad at all. It just > looks out of place if the font size is the regular dialog font size. > > Martin Klapetek wrote: > That looks good, thanks for the idea! > > > the custom presence messages still include a status such as "Away" or > "Busy" > > Nope, the "Away", "Busy" etc is replaced by the custom presence message > itself, see the "After" screenshot above. > > > So we could add a custom delegate to the combobox to have it in two-rows > > I think this would be really nice. Anyone interested in doing a > mockup/stealing that code and putting presences in it? > > Nikita Skovoroda wrote: > > http://privat.broulik.de/plasmacustomdelegate.png > > Isn't the icon good enough for that? > > What will be on the first row and what will be on the second? > > If no custom message means no second row, then i don't like if by default > (with no custom presences) there would be only huge 2-row variants with big > icons and empty second rows. > That's just wrong.
First row would always be the presence name, second the presence message (if present). I'll do a mockup tomorrow so we can see how it would look like. Might turn out it's not good at all ;) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105348/#review15112 ----------------------------------------------------------- On June 25, 2012, 7:50 p.m., Nikita Skovoroda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105348/ > ----------------------------------------------------------- > > (Updated June 25, 2012, 7:50 p.m.) > > > Review request for Telepathy and KDE Usability. > > > Description > ------- > > The bold font looks bad, especially if there is no custom presences (then > almost all variants are bold). > > Changes done by the patch: > 1) global-presence-chooser.cpp — make special presences italic. > 2) presence-model.cpp — make presences without status message not bold. > 3) presence-model.cpp — make presences with status message italic. > > This replaces «normal» font with «italic», and «bold» with «normal» in the > presence shooser. > > Looks better to me. > > > Diffs > ----- > > global-presence-chooser.cpp 6729f51 > presence-model.cpp 72bfc3d > > Diff: http://git.reviewboard.kde.org/r/105348/diff/ > > > Testing > ------- > > Does not break anything. The result is on the screenshots. > > This does not break visual separation of different status groups, when there > are a lot of custom presences (the bold entries separated them) — they can be > easily distingushed thanks to the icons. > > > Screenshots > ----------- > > Before > http://git.reviewboard.kde.org/r/105348/s/608/ > After > http://git.reviewboard.kde.org/r/105348/s/609/ > > > Thanks, > > Nikita Skovoroda > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
