> On July 12, 2012, noon, George Kiagiadakis wrote: > > contact-delegate.cpp, line 105 > > <http://git.reviewboard.kde.org/r/105514/diff/1/?file=72059#file72059line105> > > > > I'm not sure this is correct. > > > > This list will contain all the client types for the contact's current > > presence. For example, if the contact is "available" on the pc and "away" > > on the phone, this list will contain only "pc" and the presence of the > > contact will be "available". Vice versa, if the user is "available" on the > > phone and "away" on the pc, this list will contain only "phone" and the > > presence will be "available". Everything is fine up to this point. If you > > try to talk to this person, XMPP should normally choose to notify the most > > available resource of this contact, which would be the pc in the first case > > and the phone in the second case. > > > > However, if a contact is "available" on both the pc and the phone, this > > list will contain both "pc" and "phone". Therefore, if you try to talk to > > this person, she should be notified on both devices. In this case, imho, > > the phone icon should not be there, as there is at least one other client > > that is not a phone that will be notified. > > Dominik Cermak wrote: > This is not how it works, if a contact is "available" on both the pc and > the phone the list will contain only "pc" or only "phone". Which one is shown > depends on which changed to this status last. So if I'm "available" with my > pc, then connect with my phone (also "available") clientTypes would contain > only "phone" and vice versa. It works in the same way as the presence > messages.
I read the Empathy code on this, they (appear to) look at the _first_ entry in the client types list (even though that's not what the spec implies at all). (from empathy-individual-view.c on the phone icon object) + g_object_set (cell, + "visible", + !is_group + && types != NULL + && g_strv_length (types) > 0 + && !tp_strdiff (types[0], "phone"), + NULL); - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105514/#review15725 ----------------------------------------------------------- On July 11, 2012, 9:06 p.m., Dominik Cermak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105514/ > ----------------------------------------------------------- > > (Updated July 11, 2012, 9:06 p.m.) > > > Review request for Telepathy and KDE Usability. > > > Description > ------- > > This shows a phone icon left of the presence icon for contacts that are > online with a phone. > Currently it only shows the client type of 'phone' (other possible are: bot, > console, handheld, pc, web), because I think this is the most important. Also > interesting could be 'web'. > > The usability group is added for comments/discussion about the place where to > put the icon. What do you think about it? > > > This addresses bug 302963. > http://bugs.kde.org/show_bug.cgi?id=302963 > > > Diffs > ----- > > contact-delegate-compact.cpp 91f3497bac5585d922d1d6c071e3ec6b8796daa1 > contact-delegate.cpp 2b8a86398340d9b11e05e9928f9c64f396ce8e00 > main-widget.cpp 2baebe3dcbb173ea56586f765b459321bfdad6bd > > Diff: http://git.reviewboard.kde.org/r/105514/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > Full List > http://git.reviewboard.kde.org/r/105514/s/621/ > Compact List > http://git.reviewboard.kde.org/r/105514/s/622/ > Version where the icon moved to the left > http://git.reviewboard.kde.org/r/105514/s/623/ > Presence moved to the left > http://git.reviewboard.kde.org/r/105514/s/624/ > Avatar Overlay > http://git.reviewboard.kde.org/r/105514/s/625/ > Presence overlay > http://git.reviewboard.kde.org/r/105514/s/626/ > > > Thanks, > > Dominik Cermak > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
