> On July 15, 2012, 10:29 p.m., David Edmundson wrote: > > Diff got a bit messed up due to a lack of rebasing, or fetching or > > something...but ship it anyway.
For the record - between the first and second diff the master received two commits in these files, so I did a rebase on top of those two commits in my second diff, so diff2 includes parts of the patches from master while diff1 doesn't. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105477/#review15930 ----------------------------------------------------------- On July 15, 2012, 10:25 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105477/ > ----------------------------------------------------------- > > (Updated July 15, 2012, 10:25 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > This implements even smaller delegate for people who like to see looooots of > contacts at once. I'm just not sure about using smallestReadableFont(), see > screenshot - the generalFont() (on right) is good enough imho. Also the > sizeHint() still should probably take font size into account. > > > This addresses bug 303051. > http://bugs.kde.org/show_bug.cgi?id=303051 > > > Diffs > ----- > > contact-delegate-compact.h 7fa2907 > contact-delegate-compact.cpp 948e5a8 > contact-list-widget.h 724050d > contact-list-widget.cpp ee65883 > main-widget.cpp 79869b8 > > Diff: http://git.reviewboard.kde.org/r/105477/diff/ > > > Testing > ------- > > Done. > > > Screenshots > ----------- > > Mini delegate, smallest font on left, general on right > http://git.reviewboard.kde.org/r/105477/s/618/ > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
