----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105587/ -----------------------------------------------------------
(Updated July 16, 2012, 12:17 a.m.) Review request for Telepathy. Changes ------- Turns out I got shamefully tricked by kdelibs docs where it does not show the "checked" methods under "List all members" for KDualAction, but since it derives from KAction, it simply does support it. What a noob. Now it uses KDualActions and the groups button is left with the same icons for both states and uses the "checked" instead, I have to find proper icons for these actions and then switch it. But this patch is mainly about the tooltips, so let's stick to that. Please do string review as well. Description ------- This improves some tooltips over 'toolbar' actions in contact list, helps usability and accessibility. I was about to use QSignalMapper, but the behavior would be the same except there would be one more connection and two more lines of code, which I think would help nothing, so I used just one simple slot. Btw. ignore the signal mapper in the code, I just realized I left it there before uploading the patch, sorry about that. Diffs (updated) ----- main-widget.h a3bab92 main-widget.cpp 0c3eb97 Diff: http://git.reviewboard.kde.org/r/105587/diff/ Testing ------- Switched actions, looked at tooltips. Thanks, Martin Klapetek
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
