----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105829/ -----------------------------------------------------------
(Updated Aug. 3, 2012, 9:08 p.m.) Review request for Telepathy. Changes ------- Fix as per Martin's comments Summary (updated) ----------------- Fix as per review request Description (updated) ------- Fix as per review request Minor fixup Styling fixes Add error handling if the call fails to be held Add a KMessageWidget that displays any errors that might have occured when a call was paused Refactor the code a bit to look more sane Hold calls when the user presses the 'pause' button in the ui Enable the local hold state feature to listen for hold state signals Diffs (updated) ----- src/call-manager.cpp df6e7017f9fb6248c5e5488eb45f7c891d18aa0f src/call-window.h d8741c332f9ee104a00776816da968916be5ea10 src/call-window.cpp e4aed4d97eaf21f4d19613a6122be6ae96843cc7 src/call-window.ui 14144cc636880c60879e94d4936734c2002ad62e src/main.cpp 4ab3a23ba3088ca002ada134adbd95e7199bb6eb Diff: http://git.reviewboard.kde.org/r/105829/diff/ Testing ------- Successfully held and unheld calls using ktp-call-ui Thanks, Rohan Garg
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
