----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106089/#review17757 -----------------------------------------------------------
kwhiteboard/kwhiteboard.cpp <http://git.reviewboard.kde.org/r/106089/#comment13939> This is wrong. If you want to construct a string from other strings, use QString::arg(..), eg. QString objPath = QString(QString::fromLatin1("/kwhiteboard%1")).arg(++m_count); kwhiteboard/objectManager.h <http://git.reviewboard.kde.org/r/106089/#comment13940> Don't name variables "a". Use a name defining what the variable is for. kwhiteboard/objectManager.h <http://git.reviewboard.kde.org/r/106089/#comment13941> Coding style - * is aligned with the variable name (this is in a lots of places). kwhiteboard/objectManager.cpp <http://git.reviewboard.kde.org/r/106089/#comment13942> Don't create variables just for the debug output, you can do "kDebug() << "length" << objs.length() - Martin Klapetek On Aug. 20, 2012, 3:38 p.m., Puneet Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106089/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2012, 3:38 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Implemented the Object Manager Interface. Using the interface, Tabbed > Kwhiteboard is also implemented. > GetManagedObjects method of the interface is not implemented yet, and the > interface added signal is also having a parameter of QString only. > > > Diffs > ----- > > kwhiteboard/CMakeLists.txt 3bbea3c > kwhiteboard/kwhiteboard.h 43b572a > kwhiteboard/kwhiteboard.cpp deb7129 > kwhiteboard/kwhiteboardwidget.h 431ccf2 > kwhiteboard/kwhiteboardwidget.cpp ce1b2a9 > kwhiteboard/main.cpp aae48c7 > kwhiteboard/objectManager.h PRE-CREATION > kwhiteboard/objectManager.cpp PRE-CREATION > kwhiteboard/org.freedesktop.DBus.ObjectManager.xml PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106089/diff/ > > > Testing > ------- > > > Thanks, > > Puneet Goyal > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
