----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106404/ -----------------------------------------------------------
Review request for Telepathy. Description ------- Add a class providing a GlobalContact list throughout all accounts. So far 3 people have managed to get this wrong when implementing this, including Rohan, Me, George G and Dario so it would be good to have one class that does it right, also I don't like duplicate code. This is to fix Rohan's patch in the KDED module for monitoring account presences as well as removing all the duplciate code that will be in contact-request-handler. This code will also be useful for the nepomuk-service which also has an implementation of this. This will also fix the contact-request-handler not being able to display which account a new contact request comes from. Diffs ----- KTp/CMakeLists.txt fa0c741564e09c020fbe3d3e8b3d375fe9c4c3df KTp/global-contact-manager.h PRE-CREATION KTp/global-contact-manager.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106404/diff/ Testing ------- Thanks, David Edmundson
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
