----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106507/#review19227 -----------------------------------------------------------
This review has been submitted with commit e7868e7e27f2eb21f537735bc39160855034846d by David Edmundson to branch kde-telepathy-0.5. - Commit Hook On Sept. 19, 2012, 4:35 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106507/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2012, 4:35 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Hide presence applet if you have no accounts. We want distributions to add > the presence-applet by default to the systray as it makes everything work > better. > However, for people who don't use IM having an extra icon there would be > annoying. > > This hides the icon using Plasma item status, and makes it appear only unhide > if you have an account already or add one. By hidden, I mean make it appear > not in the main system tray but in the silly little pop-out arrow where > hidden sys-tray icons go. > > Request adding to 0.5 branch. > > It doesn't check when you remove accounts (until next login), this is partly > by design as it's generally bad for icons to mysteriously disappear (and > partly due to laziness/wanting to keep this patch simple to add to 0.5). > > For 0.6 I've heard someone suggest we should set status depending if you're > online/offline. Needs discussion. > > > Diffs > ----- > > src/presenceapplet.h 2de67ac1a927bac37e2adc51884dafa22da04b5c > src/presenceapplet.cpp aa843c9332cb6d116837d73cbe9f58f9ad504495 > > Diff: http://git.reviewboard.kde.org/r/106507/diff/ > > > Testing > ------- > > Removed all my accounts. Checked it was hidden on first login, and reappeared > when I added an account. > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
