> On Sept. 25, 2012, 8 p.m., David Edmundson wrote: > > ../../defaults/chat-widget.h, line 89 > > <http://git.reviewboard.kde.org/r/106575/diff/1/?file=87139#file87139line89> > > > > Both these should be private
saveSpellCheckingOption(); is called somewhere outside the chat-widget class-In class ChatWindow (file chat-window.cpp), function setTabSpellDictionary(const QString &dict), through an inherited object(instance). I can set the loadSpellCheckingOption(); only as private though, or set them both and create a wrapper public function in chat-widget.cpp that calls the private saveSpellCheckingOption(). - Nick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106575/#review19420 ----------------------------------------------------------- On Sept. 25, 2012, 7:52 p.m., Nick Lou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106575/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2012, 7:52 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Fix for the reported Bug 291764 (Set spellchecking language per contact > instead of per tab). > If a contact changes the default spellchecking option to one of his/her > choice, > the new option is saved in a file as a pair, target Id and spell checking > option, > where the target Id is a group and option value has a key named "language". > > > This addresses bug 291764. > http://bugs.kde.org/show_bug.cgi?id=291764 > > > Diffs > ----- > > ../../defaults/chat-widget.h 7d2dcf2 > ../../defaults/chat-widget.cpp 6c9c7ed > ../../defaults/chat-window.cpp eb1b7a0 > > Diff: http://git.reviewboard.kde.org/r/106575/diff/ > > > Testing > ------- > > Tested it by changing the spellchecking option of various pairs, > and then by closing and reopening their chat tabs and checking the values. > I also checked the values stored in the config file. > > > Thanks, > > Nick Lou > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
