----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106355/#review19542 -----------------------------------------------------------
Ship it! Nice! contactnotify.h <http://git.reviewboard.kde.org/r/106355/#comment15512> this is unused. contactnotify.cpp <http://git.reviewboard.kde.org/r/106355/#comment15511> const & contactnotify.cpp <http://git.reviewboard.kde.org/r/106355/#comment15515> add a comment explaining what this is meant to do. i.e "show notifications when a contact becomes more available" contactnotify.cpp <http://git.reviewboard.kde.org/r/106355/#comment15513> these are going to flood ~.xmessages. I would suggest removing these contactnotify.cpp <http://git.reviewboard.kde.org/r/106355/#comment15514> const & - David Edmundson On Sept. 28, 2012, 9:25 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106355/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2012, 9:25 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Minor styling fixup > > > Make sure that the connection and contacts actually exist before doing > anything > > This change makes the code a bit more asynchronous and uses the right > eventID for notifications > > Implement contact notifications > > > Diffs > ----- > > CMakeLists.txt 96cedcff5a09eb26217b9032a68f4b4e01768805 > contactnotify.h PRE-CREATION > contactnotify.cpp PRE-CREATION > telepathy-module.h 15666bcebf6d4b1d9640e016ff8d6202471b7629 > telepathy-module.cpp 2085fea3d133db388e43c47ee8b0f3af8d5279cd > > Diff: http://git.reviewboard.kde.org/r/106355/diff/ > > > Testing > ------- > > Notifications from specific contacts were shown. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/106355/s/718/ > > > Thanks, > > Rohan Garg > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
