----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106635/#review19600 -----------------------------------------------------------
Ship it! I want this committed the 0.5 branch too Also be sure to update krunner. - David Edmundson On Sept. 29, 2012, 3:52 p.m., Dan Vratil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106635/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2012, 3:52 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Starting logviewer with preselected Facebook contact fails, because Facebook > contacts UIDs start with "-", so KCmdLineArgs interprets it as an (invalid) > argument and fails to start logviewer. > > This patch changes logviewer cmd line syntax to > > ktp-log-viewer accountID,contactID > > i.e. passing accountID and contactID as a single argument and separating them > just by comma. This assumes comma is not an allowed character within > accountID and contactID, which I believe is a safe assumption. > > > This addresses bug 307577. > http://bugs.kde.org/show_bug.cgi?id=307577 > > > Diffs > ----- > > app/chat-window.cpp 57cc33f > logviewer/entity-view.cpp 69c408f > logviewer/main.cpp f960c2a > > Diff: http://git.reviewboard.kde.org/r/106635/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vratil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
