----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106688/#review19788 -----------------------------------------------------------
Ship it! Nice patch, thanks, I'm also fine with the logger being a dependency. context-menu.h <http://git.reviewboard.kde.org/r/106688/#comment15740> As you can see, all the the methods around use the onSomethingSomethingTriggered();, so please use the same style (just add "Triggered" at the end) context-menu.cpp <http://git.reviewboard.kde.org/r/106688/#comment15741> This should have "..." at the end, ie. "Open Log Viewer..." (and also capitalize all the words) context-menu.cpp <http://git.reviewboard.kde.org/r/106688/#comment15743> Ooooh...not really good, but as d_ed pointed out, it's moreless the only way now. Good thing I added the ContextMenu as a friend class :D (also, reminding d_ed to re-push) - Martin Klapetek On Oct. 2, 2012, 12:56 p.m., Dan Vratil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106688/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2012, 12:56 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > This adds "Open log viewer" action to contact context menu in contact list. > The action is disabled when there are no logs to display - because of that > contact list needs to be linked against TelepathyLoggerQt4, so I added it as > a hard dependency. > > > Diffs > ----- > > CMakeLists.txt 7cb36cf > context-menu.h 5a30c6d > context-menu.cpp 10f3d90 > > Diff: http://git.reviewboard.kde.org/r/106688/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vratil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
