----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106694/#review19791 -----------------------------------------------------------
Ship it! Few notes below.. src/accounts-list-model.cpp <http://git.reviewboard.kde.org/r/106694/#comment15744> Since the AccountItem is being removed, it makes sense for the slots to use onAccountUpdated() instead of onAccountItemUpdated() (just do ctrl+r) src/accounts-list-model.cpp <http://git.reviewboard.kde.org/r/106694/#comment15746> Shouldn't this use the presence icon? - Martin Klapetek On Oct. 2, 2012, 6:41 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106694/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2012, 6:41 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Remove somewhat pointless AccountItem class. > > This should result in a simpler, faster AccountsModel. > > The old code had some icon overlaying, which would never do anything (a > misunderstanding of isValid()), and making lots of new QObjects. > > > Diffs > ----- > > src/CMakeLists.txt ee82fd0f82b3c158f1bef670b08120ef22974b6c > src/account-item.h a2fee834c7e0e65931fa82c437be754e95ec333c > src/account-item.cpp 8efc78fb135b7cf29b750fcfeb11c1b94eaa44a6 > src/accounts-list-model.h 10786674ab0d5a7bada9f6b3e3be9acd0aa235cd > src/accounts-list-model.cpp 4a015fa517c625099f4fb05da3572e53b243d2ad > > Diff: http://git.reviewboard.kde.org/r/106694/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
