----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107012/#review20747 -----------------------------------------------------------
>From a code POV, it's good (except for the _massive_ bug that you copied and >pasted.) >From a usability request, why would you deny if you didn't want to block as >well? It seems having 3 options is a bit redundant IRL, and I would propose >merging with deny. contact-request-handler.cpp <http://git.reviewboard.kde.org/r/107012/#comment16377> NO! The code has the potential to infinite loop!!!!!! the ++i should be outside the if. I've just noticed you copied and pasted this. So well done for helping me fix a bug! I've been wondering where that existing 100% CPU usage bug came from. contact-request-handler.cpp <http://git.reviewboard.kde.org/r/107012/#comment16376> Just because the original codebase has stupid comments, doesn't allow you to copy them :P - David Edmundson On Oct. 23, 2012, 3:59 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107012/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2012, 3:59 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Add an option to block an incoming contact. This can be used to prevent a > notification to be shown when being spammed with new contact requests. > > > This addresses bugs 297994 and 308809. > http://bugs.kde.org/show_bug.cgi?id=297994 > http://bugs.kde.org/show_bug.cgi?id=308809 > > > Diffs > ----- > > contact-request-handler.h 43456ee > contact-request-handler.cpp ea24885 > > Diff: http://git.reviewboard.kde.org/r/107012/diff/ > > > Testing > ------- > > Works fine. Once blocked, notification does not reappear. User can also > accept a blocked request after unblocking the contact and resending contact > authorization. > > > Thanks, > > Rohan Garg > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
