----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107033/#review20854 -----------------------------------------------------------
The patch looks ok, but testing it I found another related bug: Steps to reproduce: Method 1) - Close all wallets - Start ktp-accounts-kcm - Click edit for one account (the kwallet dialog pops up) - Insert kwallet password - Close the edit dialog - Close all wallets again - Click edit for one account Method 2) - Close all wallets - Start ktp-accounts-kcm - Click edit for one account (the kwallet dialog pops up) - Hit cancel on kwallet dialog (The edit dialog this time is shown with the password blank) - Close the edit dialog - Click edit for one account This time kwallet dialog does not pop up but since the wallet is locked the edit dialog is not shown. When you close the kcm module it causes a segfault. On the other hand even if without the patch it shows the ugly useless version of the edit dialog, it doesn't seem to cause the segfault, so this patch must be causing it, so I'm not sure if we should ship it without fixing this bug... - Daniele Elmo Domenichelli On Oct. 25, 2012, 9:24 a.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107033/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2012, 9:24 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Wait until KWallet is opened, then allow dialog to be shown. Otherwise you > see just an empty dialog with "OK" and "Cancel" buttons. > > > This addresses bug 308079. > http://bugs.kde.org/show_bug.cgi?id=308079 > > > Diffs > ----- > > src/edit-account-dialog.h 08a3481 > src/edit-account-dialog.cpp a747242 > > Diff: http://git.reviewboard.kde.org/r/107033/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
