> On Oct. 28, 2012, 8:22 p.m., Martin Klapetek wrote: > > Nice, thanks!
To save the inevitable follow up question. I am not pushing this to the 0.5 branch, because even though it does fix a bug, it changes the dbus interfaces. This means 0.5.3 of the applet with 0.5.2 of the contact list would break heavily. I think everything in a 0.x series should be compatible. (it's only a minor bug anyway) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107046/#review21064 ----------------------------------------------------------- On Oct. 26, 2012, 5:35 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107046/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2012, 5:35 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Remove DbusExporter class, only register service name. Ref count usages to > know when to remove. > > This simplifies code and removes a bug in which if you add two plasmoids, > then remove the first one, we no longer appear to be running. > > BUG: 305614 > > > Diffs > ----- > > src/presenceapplet.h 5b462fcda7e3330089dae4762fb671f5c9cc5983 > src/presenceapplet.cpp 33fc8cc7fe931b7212278237b0ca0cae7d53ed02 > > Diff: http://git.reviewboard.kde.org/r/107046/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
