----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107151/#review21276 -----------------------------------------------------------
This review has been submitted with commit c4ee109a419ed68a8f0c635ac0192836a9e177cd by Daniele E. Domenichelli to branch filters. - Commit Hook On Oct. 31, 2012, 2:38 p.m., Daniele Elmo Domenichelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107151/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2012, 2:38 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Configure version in CMakeLists.txt instead of in main.cpp > > I would like to merge this also in the stable branch even if it adds the > version.h.in file, since it simplifies handling the version and avoids stupid > errors ("AdiumXtra Protocol Handler" version is at the moment "0.3.60") > > > Diffs > ----- > > CMakeLists.txt 1d1d72b877348ade85e4835e8e586b3c18ffc11e > adiumxtra-protocol-handler/main.cpp > 8610008b5ba7bc5b6da13b689b05709ff9b3198e > app/main.cpp e6ac76ac8fae6882226c7f2dca6f4d007b283b66 > logviewer/main.cpp 98c5123f659e3eb71d36a4070c173fd403eb585e > version.h.in PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/107151/diff/ > > > Testing > ------- > > ktp-text-ui --version > ktp-logviewer --version > ktp-adiumxtra-protocol-handler --version > > > Thanks, > > Daniele Elmo Domenichelli > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
