----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107408/#review22372 -----------------------------------------------------------
This review has been submitted with commit 6857be3a56573a91e8bd76bb874375cfd5793348 by Dan Vrátil to branch master. - Commit Hook On Nov. 21, 2012, 3:55 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107408/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2012, 3:55 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > This patch adds following main menu to the logviewer main window: > > File > - Quit > Logs > - Clear account history > - Clear contact history > ----------------------- > - Import Kopete Logs > Conversation > - Previous Conversation (Ctrl+P) > - Next Conversation (Ctrl+N) > Settings > Help > > (The last two menus contain default KXmlGuiWindow actions, I decided to omit > the "Glorify dvratil" action). > > I converted the LogViewer class from QWidget to KXmlGuiWindow and since I was > already digging in the code, I moved the Tp Factories initialization to > main(), renamed some slots, moved some code etc - no major changes, it just > makes me happier when reading the code. > > The new feature (because of which I decided to do this all) are "Previous > Conversation" and "Next Conversation" actions. I'm bored scrolling all the > way up in long chats to reach the "Previous Conversation" link on the > beginning of the log. Having these two actions allows me to do this just by > using keyboard shortcuts ;) > > > Diffs > ----- > > logviewer/CMakeLists.txt 3953dc1 > logviewer/log-viewer.h 8829e7b > logviewer/log-viewer.cpp 13db0c4 > logviewer/log-viewer.rc PRE-CREATION > logviewer/main.cpp e7eb0b5 > > Diff: http://git.reviewboard.kde.org/r/107408/diff/ > > > Testing > ------- > > Looks like everything still works. > > > Thanks, > > Dan Vrátil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
