> On Nov. 22, 2012, 1:36 p.m., Daniele Elmo Domenichelli wrote: > > Screenshot: After > > <http://git.reviewboard.kde.org> > > > > I didn't check the patch, but there is still something wrong in the > > alignment here... > > Also the scrollbar disappeared, so I wonder if you can still scroll to > > get the items that disappear if the i18n'ed names are long > > Othmane Moustaouda wrote: > In order to show the difference I had to resize the window at the minimum > size possibile, the list widget appears as truncated because its minimum size > is the size that contains all items
Imho this is fix will cause other problems, but there is probably no easy solution. By looking at what Amarok does I found that their list widget is just big enough to show the scrollbar when needed, without changing the item disposition, see http://wstaw.org/m/2012/11/23/snapshot111.png , but it looks better because they have bigger icons. What do you think? - Daniele Elmo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107417/#review22378 ----------------------------------------------------------- On Nov. 22, 2012, 11:03 a.m., Othmane Moustaouda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107417/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2012, 11:03 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > This single line patch fixes bug 309819 - "Now playing settings groupbox has > wasted empty space" > > > This addresses bug 309819. > http://bugs.kde.org/show_bug.cgi?id=309819 > > > Diffs > ----- > > config/nowplaying-listwidget.cpp 0262f48553537470d34e29b9b0b1450eca855ce8 > > Diff: http://git.reviewboard.kde.org/r/107417/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > Before > http://git.reviewboard.kde.org/r/107417/s/847/ > After > http://git.reviewboard.kde.org/r/107417/s/848/ > > > Thanks, > > Othmane Moustaouda > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
