----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107500/#review22680 -----------------------------------------------------------
KTp/Models/accounts-filter-model.cpp <http://git.reviewboard.kde.org/r/107500/#comment17332> Please remove the extra white spaces KTp/Models/accounts-filter-model.cpp <http://git.reviewboard.kde.org/r/107500/#comment17333> good catch, thanks. KTp/Models/accounts-filter-model.cpp <http://git.reviewboard.kde.org/r/107500/#comment17334> Is there a reason why you are not filtering like in the above lines here? - Daniele Elmo Domenichelli On Nov. 28, 2012, 2:05 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107500/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2012, 2:05 a.m.) > > > Review request for Telepathy and Daniele Elmo Domenichelli. > > > Description > ------- > > This patch add Id into filterable string, id also contains some useful > string, for gabble it's something like email address. > > And when globalFilterString is not empty, filterFunction always return true, > add return false at last if globalFilterString is not empty. > > > Diffs > ----- > > KTp/Models/accounts-filter-model.h b0d7402 > KTp/Models/accounts-filter-model.cpp eeecc77 > > Diff: http://git.reviewboard.kde.org/r/107500/diff/ > > > Testing > ------- > > Compiles, No problem. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
