----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107547/#review22878 -----------------------------------------------------------
Nice! Just next time try to compile the code before submitting the patch ;) Also we should probably let David check the English :) config/appearance-config.cpp <http://git.reviewboard.kde.org/r/107547/#comment17450> This does not compile. i18nc() takes two arguments - a comment for translators and the string to translate. If you don't want to have any comment, use i18n() This applies to more places. config/appearance-config.cpp <http://git.reviewboard.kde.org/r/107547/#comment17457> @gmail.com is not a good choice. Let's stick with @example.com or something that actually won't cause innocent people to get spammed :) config/appearance-config.cpp <http://git.reviewboard.kde.org/r/107547/#comment17452> Use capitals at the beginning of sentences (applies below too) config/appearance-config.cpp <http://git.reviewboard.kde.org/r/107547/#comment17453> Don't use lazy speak - u -> you config/appearance-config.cpp <http://git.reviewboard.kde.org/r/107547/#comment17451> Telepath -> Telepathy "step-by-step instruction" - either "instructions" or "instruction manual" or "instruction guide" config/appearance-config.cpp <http://git.reviewboard.kde.org/r/107547/#comment17458> Spaces around the + operator config/appearance-config.cpp <http://git.reviewboard.kde.org/r/107547/#comment17454> ..started improving the demo... config/appearance-config.cpp <http://git.reviewboard.kde.org/r/107547/#comment17459> Spaces around operators config/appearance-config.cpp <http://git.reviewboard.kde.org/r/107547/#comment17455> of imporved -> of the improved kde -> KDE config/appearance-config.cpp <http://git.reviewboard.kde.org/r/107547/#comment17456> now I must -> I must now fo -> go cos -> because config/appearance-config.cpp <http://git.reviewboard.kde.org/r/107547/#comment17460> probably should be "i" - otherwise it won't build - Dan Vrátil On Dec. 1, 2012, 4:35 p.m., Illya Kovalevskyy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107547/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2012, 4:35 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > I have rewritten the demo for chat for Telepathy. > > > Diffs > ----- > > config/appearance-config.cpp a88dd02 > > Diff: http://git.reviewboard.kde.org/r/107547/diff/ > > > Testing > ------- > > > Thanks, > > Illya Kovalevskyy > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
