----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107773/#review23590 -----------------------------------------------------------
This review has been submitted with commit a75ac9592499aab85bdf1be34fb81a913413d709 by Dan Vrátil to branch master. - Commit Hook On Dec. 16, 2012, 11:44 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107773/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2012, 11:44 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Praise my insomnia! As David suggested, I've stolen code from Konversation > and simplified it a bit so that it supports only "Inline cycle" completion > mode, uses ", " as suffix when completing on start of line, no suffix in > middle of line. No settings to change it :P > > I'm not sure why data() and rowCount() in ChannelContactModel were protected, > by I had to make them public. > > > This addresses bug 291709. > http://bugs.kde.org/show_bug.cgi?id=291709 > > > Diffs > ----- > > lib/channel-contact-model.h 55840ea > lib/channel-contact-model.cpp 619e9ad > lib/chat-text-edit.h a8b0e79 > lib/chat-text-edit.cpp 9babc73 > lib/chat-widget.h 30a24e0 > lib/chat-widget.cpp d5608df > > Diff: http://git.reviewboard.kde.org/r/107773/diff/ > > > Testing > ------- > > Tested briefly, seems to work :) > > > Thanks, > > Dan Vrátil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
