----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108018/#review24231 -----------------------------------------------------------
This review has been submitted with commit 610e9a4585e87d837332af2ac074e49f1de38bc3 by Dan Vrátil to branch model_refactor_2. - Commit Hook On Dec. 30, 2012, 2:17 a.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108018/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2012, 2:17 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > AccountsTreeProxyModel > - remove debugging messages (looks useless to me) > > ContactsFilterModel > - make OnlineUsersCountRole and TotalUsersCountRole work with > ContactsListModel as source model. Did not test with ContactsModel, but it > should now work with both of them (essentially I had to port the code away > from GroupsModelItem and AccountsModelItem since these are > ContactsModel-specific). > > ContactsListModel > - emit changed() when contact's group membership changes > > > Diffs > ----- > > KTp/Models/abstract-grouping-proxy-model.cpp 533d545 > KTp/Models/accounts-tree-proxy-model.h 98bab16 > KTp/Models/accounts-tree-proxy-model.cpp e5ad725 > KTp/Models/contacts-filter-model.cpp 269505c > KTp/Models/contacts-list-model.cpp 219ee5f > > Diff: http://git.reviewboard.kde.org/r/108018/diff/ > > > Testing > ------- > > ContactsFilterModel > - online/total contacts counts are correctly displayed with both grouping > types > > ContactsListModel > - moving contact to a different group updates the model as expected > > > Thanks, > > Dan Vrátil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
