On Friday 04 of January 2013 13:34:34 Daniel Vrátil wrote: > Hi, > > I'm starting the planned move of all declarative components to ktp-common- > internals and all Plasma applets to ktp-contact-applet (to be renamed to > ktp- desktop-applets). > > Please don't to commit changes to master branches of these repos (or I'll > force you to do the merging afterwards!). > > It should take just a few days. I'll keep you updated on the progress.
This was easier then I thought, hehe :)
ktp-common-internals
All declarative modules all now merged to ktpqmlplugin.so (import
org.kde.telepathy 0.1). Sources are in
ktp-common-internals/KTp/Declarative.
Because the declarative plugin from text-ui depends on some code from
libktpchat, I had to move following classes from libktpchat to
libktpcommoninternalsprivate:
AbstractMessageFilter => KTp::AbstractMessageFilter
Message => KTp::Message
MessageProcessor => KTp::MessageProcessor
PluginConfigManager => KTp::MessageFilterConfigManager
UrlFilter => MessageUrlFilter (not exported)
EscapeFilter => MessageEscapeFilter (not exported)
ktp-text-ui has been updated to use the moved and namespace'd classes.
I
also d-pointer'ized them where it was necessary. I have also moved tests
from text-ui to ktp-common-internals/tests, since these tests
cover only the
moved classes.
Moving these classes also means, that ktp-active and can implement it's
own
filters without having a binary dependency on ktp-text-ui. Until we come
with a better solution, ktp-desktop-applets and ktp-active will have to
have
run-time dependency on ktp-text-ui in order to have filters available.
ktp-contact-applet (to be renamed to ktp-desktop-applets)
This module now contains all Plasma applets we have so far in official
repos. I fixed the names to all use the same format, so now we have:
chat plasmoid: org.kde.ktp-chatplasmoid
contact applet: org.kde.ktp-contact
contact list applet: org.kde.ktp-contactlist
presence applet: org.kde.ktp-presence
I also normalized the .desktop files naming to use dash instead of
underscore (most files in /usr/share/kde4/services/ use dash).
Found a minor issue though: after restarting Plasma, all my KTp applets
were
gone because of the renaming...
ktp-presence-applet
Gone.
Other modules are intact and should not even need recompiling.
ktp-common-internals, ktp-contact-applet and ktp-text-ui now all have
move_plasma branches. Everyone is welcomed to review the changes and test.
Dan
>
> Cheers,
> Dan
>
> --
> [email protected] | Associate Software Engineer / BaseOS / KDE, Qt
> GPG Key: 0xC59D614F6F4AE348
> Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348
--
[email protected] | Associate Software Engineer / BaseOS / KDE, Qt
GPG Key: 0xC59D614F6F4AE348
Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
