-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107995/
-----------------------------------------------------------
(Updated Jan. 5, 2013, 1:11 p.m.)
Review request for Telepathy.
Changes
-------
address issues from previous reviews.
Description
-------
Check in SimpleProfileSelectWidget if required connection managers are installed
* new cmake option -DPACKAGE_INSTALLATION=[apt,packagekit]
* default: no package installation enabled just promt a message
* on the first page of AddAccountAssistant profiles with no CM installed will
be disabled
Diffs (updated)
-----
src/KCMTelepathyAccounts/CMakeLists.txt
e19f3accf465f852012d251f69bbfa2ff372bb7f
src/KCMTelepathyAccounts/package-install-action.h PRE-CREATION
src/KCMTelepathyAccounts/package-install-action.cpp PRE-CREATION
src/KCMTelepathyAccounts/profile-list-model.h
8b313d19765b63071408047b5d183ecc419500de
src/KCMTelepathyAccounts/profile-list-model.cpp
12752928f377552a323a502557d2717819c257de
src/KCMTelepathyAccounts/simple-profile-select-widget.h
52eede1c4d5b7a39143b71c19f33dcb965827bf9
src/KCMTelepathyAccounts/simple-profile-select-widget.cpp
5f9a516e74a17c8cf86a5f5382d5071baff1c8a8
src/KCMTelepathyAccounts/simple-profile-select-widget.ui
5ad8e79a7bd4fd6d52dac61cbd88becb0cd569ae
Diff: http://git.reviewboard.kde.org/r/107995/diff/
Testing
-------
* remove telepathy-haze
* start the kcm
* result see screenshot
Screenshots
-----------
telepathy-haze not installed
http://git.reviewboard.kde.org/r/107995/s/937/
Thanks,
Florian Reinhard
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
