-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108500/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
Based on what Martin suggested in the bug report, I extended the behaviour by
also showing an icon when there's an unread message. The icons work as
following:
Tab icon:
When there is an unread message in a tab, show "unread message" icon. When
there are no unread messages and someone in the chat is typing, show "typing"
icon. Otherwise show presence icon. The reasoning is that you are probably more
interested in the fact that there is an unread message, than that someone is
typing.
Window icon:
When there is an unread message in ANY tab, show "unread message" icon. When
there are no unread messages in any tab and someone in CURRENT tab is typing,
show "typing" icon. Otherwise show presence icon of current tab. The reasoning
again is that you are most interested in the fact that somewhere there is an
unread message. The "typing" icon is shown only for current tab, because it
might get confusing why the window is indicating "typing" when the current user
is not typing.
This addresses bug 311859.
http://bugs.kde.org/show_bug.cgi?id=311859
Diffs
-----
app/chat-window.h 5a90c91
app/chat-window.cpp b48f148
Diff: http://git.reviewboard.kde.org/r/108500/diff/
Testing
-------
Thanks,
Dan Vrátil
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
