----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108502/#review25839 -----------------------------------------------------------
Ship it! Please read comment 2. src/kcm-telepathy-accounts.cpp <http://git.reviewboard.kde.org/r/108502/#comment19728> Well spotted! src/kcm-telepathy-accounts.cpp <http://git.reviewboard.kde.org/r/108502/#comment19727> That was really confusing, I spent a while on this. Could you add in a comment //If the model changes, and that change is the selected index, then we update the edit button state. Alternately - you could replace all this with if (m_currentListView) { onSelectedItemChanged(m_currentListView->currentIndex(), m_currentListView->currentIndex()) } this saves having duplicated code. I prefer mine, but yours works... so it's up to you. - David Edmundson On Jan. 20, 2013, 4:10 a.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108502/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2013, 4:10 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > 1) Fix enabling/disabling of the "Edit Identity" button when switching > between "local XMPP" listview and the accounts listview. The problem was that > both, accounts listview and the "local XMPP" listview were emitting > "onCurrentChanged" signal. Usually accounts listview delivered the signal > earlier and cancelled the selection in the "local XMPP" listview, therefore > you had to sometimes click twice and the "Edit Identity" button was not > enabled/disabled correctly. > > 2) Automatically enable/disable the "Edit Identity" button when current > account is connected/disconnected. > > > This addresses bug 291653. > http://bugs.kde.org/show_bug.cgi?id=291653 > > > Diffs > ----- > > src/kcm-telepathy-accounts.h d4802db > src/kcm-telepathy-accounts.cpp 9ca5949 > > Diff: http://git.reviewboard.kde.org/r/108502/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
