----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108508/#review25859 -----------------------------------------------------------
lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/108508/#comment19736> This call should not depend on whether a pixmap was succesfuly loaded. lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/108508/#comment19735> The comment is related tonotification->addContext() so it should be moved to the call - Dan Vrátil On Jan. 20, 2013, 5:34 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108508/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2013, 5:34 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Always check message.sender() before using it as it may be NULL. > > This is for the stable branch as well as master. > > > Diffs > ----- > > lib/chat-widget.cpp bbc8451de07dd6b1072b73eadfa4c457fbde0c06 > > Diff: http://git.reviewboard.kde.org/r/108508/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
