----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108558/#review26012 -----------------------------------------------------------
What about calling the method setCurrentAccount, so that it's complimentary to currentAccount() and it's more clear that it can be used anytime to change selection. Bonus for the documentation :) KTp/Widgets/accounts-combo-box.cpp <http://git.reviewboard.kde.org/r/108558/#comment19839> This should be itemData(i, role) I guess - Dan Vrátil On Jan. 22, 2013, 8:30 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108558/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2013, 8:30 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Add a method to AccountsComboBox to pre-select an account. > > This came up from porting the call UI. Not having this will result in a > regression (one could do it by looping through the QComboBox, but I'd rather > internalise everything). Will probably be useful for Join Chat Room dialog > too. > > > Diffs > ----- > > KTp/Widgets/accounts-combo-box.h b5a17dacabd2428d46788028507995de129eb556 > KTp/Widgets/accounts-combo-box.cpp d1ffbacd44e3e5d525ad4bd0c153defbfa9709f1 > > Diff: http://git.reviewboard.kde.org/r/108558/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
