----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108566/#review26117 -----------------------------------------------------------
The patch does not apply on ktp-call-ui master. From the diff it seems that you are missing at least commit 6729cc86b61d62d473728a4f5a8350d438a64d59 (which is weird, because it's your commit) - Dan Vrátil On Jan. 23, 2013, 6:37 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108566/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2013, 6:37 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Remove private gabble hack, instead use KTp::Contact which has it inbuilt > > > Use KTp::Actions for starting audio/video call > > > Port dialout widget to AccountsComboBox rather than old models > > Also fixes loading/saving the last used accounts in the UI, using a model > index isn't very reliable if the accounts change. > > > Diffs > ----- > > src/dialout/CMakeLists.txt b547847b675ca4d3aedc684e96ea40f94381c76c > src/dialout/dialout-widget.h 5c201a149c1a2110832a634b850a256f8ecc9b00 > src/dialout/dialout-widget.cpp 3fac58f46b261225abddcfbf5f6c53630a91a875 > src/dialout/dialout-widget.ui 8c40e74edd16f31eb542d9d4a1a6ede83f2698f8 > > Diff: http://git.reviewboard.kde.org/r/108566/diff/ > > > Testing > ------- > > Opened dial out UI. Check accounts were filtered, checked buttons were > enabled when typing a correct contact address. > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
