----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108831/#review26866 -----------------------------------------------------------
The issue of what KDE SC versions we support came up recently (something to do with kdepimlibs and emoticons) In that discussion we decided we support latest and latest -1. We can't rely on the very very latest because we risk putting off new developers (and the oldies here who use Debian). There's no point breaking that for the sake of a slightly improved icon. I originally did the delegate like this to match Device Notifier, and the plasma delegate looked awful (> 1 year ago at least). If it looks better, ship it. contactlist/org.kde.ktp-contactlist/contents/ui/ListContactDelegate.qml <http://git.reviewboard.kde.org/r/108831/#comment20341> This also changes the click behaviour from double click. Quite a significant change. We can do it but we should monitor feedback from people between now and release. - David Edmundson On Feb. 7, 2013, 4:35 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108831/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2013, 4:35 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > This patch does 2 main things: > - cleans up the delegate to use PlasmaComponents.ListItem instead of a custom > highlighter. > - Fixes the plasmoid initialization, when setting the sorting and filter. it > was using .model instead of .filter. (it wasn't filtering or sorting anything > before...) > - Prefer IconItem to QIconItem, this is better because it's a little smarter > and more efficient (see marco's blog posts). It has a downside that adds a > dependency on KDE 4.10, which I'm unsure if it's acceptable. > > Hope you like it! > > > Diffs > ----- > > contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml 2f0ea05 > contactlist/org.kde.ktp-contactlist/contents/ui/ListContactDelegate.qml > 9bf73d8 > > Diff: http://git.reviewboard.kde.org/r/108831/diff/ > > > Testing > ------- > > I ran the contact list on the plasmoid viewer while coding > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list KDE-Telepathy@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy
