----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109202/#review28259 -----------------------------------------------------------
app/chat-window.cpp <http://git.reviewboard.kde.org/r/109202/#comment21114> app/chat-window.cpp <http://git.reviewboard.kde.org/r/109202/#comment21115> if you have a qobject always use qobject_cast app/chat-window.cpp <http://git.reviewboard.kde.org/r/109202/#comment21116> our coding style dictates that it's always if () { } with braces even for single lines. There's actually some code in the text-ui working around a bug in kdelibs because someone didn't use braces and the "if" misses a step. Relevant link: http://techbase.kde.org/Policies/Kdelibs_Coding_Style/en As for the problem, one possibly solution: KActionCollection has a static method to return the actionCollections in the application, from here you can grab the action, from that you can get the shortcut. - David Edmundson On Feb. 28, 2013, 1:51 p.m., Roman Nazarenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109202/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2013, 1:51 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > The patch is a mess. QTextEdit handles Key_Return, we need to save Key_Return > from passing to QTextEdit, but we need to know KAction shortcut. And that > shortcut is stored in ChatWindow, which is located far away in the QObject > parenting tree. > This patch allows user to configure custom shortcut, but standard shortcut > (Key_Return) is still working. I have no idea how to disable it without types > casting hell. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=308894. > > http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=308894 > > > Diffs > ----- > > app/chat-window.h 018e91a > app/chat-window.cpp c79e3aa > lib/chat-text-edit.h 4279ce5 > lib/chat-text-edit.cpp 19fdb38 > lib/chat-widget.h 2c85f3b > lib/chat-widget.cpp e7adc5a > > Diff: http://git.reviewboard.kde.org/r/109202/diff/ > > > Testing > ------- > > > Thanks, > > Roman Nazarenko > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
