----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109209/#review28271 -----------------------------------------------------------
Well, then you probably want to make sure they're all the same version anyway. ktp-common-internals is not ensuring binary compatibility, and it's fine, IMHO. But that's your call, you're the maintainer. I fail to see, why it's better to have the version moved from main.cpp -> CMakeLists.txt then - Aleix Pol Gonzalez On Feb. 28, 2013, 3:30 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109209/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2013, 3:30 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Move version information into CMakeLists.txt > > This will make releases a bit easier > > > Diffs > ----- > > CMakeLists.txt 1ba261c2f3c90616a6a60200cc1ba397a846e90a > main.cpp d7d0febabfedf06e31003bb0c1e19760cf335ea7 > version.h.in PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109209/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list KDE-Telepathy@kde.org https://mail.kde.org/mailman/listinfo/kde-telepathy