----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109465/#review29161 -----------------------------------------------------------
filters/latex/latex-config.cpp <http://git.reviewboard.kde.org/r/109465/#comment21766> what would be cool is to run KStandardDirs::findExe on latex and dvipng and show a warning message at the top of the config ui if either is missing filters/latex/latex-filter.cpp <http://git.reviewboard.kde.org/r/109465/#comment21764> coding standard {} are mandatory filters/latex/latex-filter.cpp <http://git.reviewboard.kde.org/r/109465/#comment21765> If someone sets the latex command to "" this now crashes. check latexCmd.size() somewhere. As discussed earlier this can't get into 0.6.0, but please please push a branch so it's not lost. You can also release is separately as a tarball if you like. I can help. - David Edmundson On March 13, 2013, 7:36 p.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109465/ > ----------------------------------------------------------- > > (Updated March 13, 2013, 7:36 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > A more configurable version of the latex plugin in > https://git.reviewboard.kde.org/r/106083/ > > > Diffs > ----- > > filters/CMakeLists.txt 62384cb > filters/latex/CMakeLists.txt PRE-CREATION > filters/latex/kcm_ktptextui_message_filter_latex.desktop PRE-CREATION > filters/latex/ktptextui_message_filter_latex.desktop.cmake PRE-CREATION > filters/latex/latex-config.h PRE-CREATION > filters/latex/latex-config.cpp PRE-CREATION > filters/latex/latex-config.ui PRE-CREATION > filters/latex/latex-filter.h PRE-CREATION > filters/latex/latex-filter.cpp PRE-CREATION > filters/latex/latex.kcfg PRE-CREATION > filters/latex/latexconfig.kcfgc PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109465/diff/ > > > Testing > ------- > > Sent some latex code in a conversation > > > File Attachments > ---------------- > > Latex filter example and configure > > http://git.reviewboard.kde.org/media/uploaded/files/2013/03/13/latex_filter_1.png > > > Thanks, > > Andrea Scarpino > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
