----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109432/#review29194 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On March 13, 2013, 4:25 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109432/ > ----------------------------------------------------------- > > (Updated March 13, 2013, 4:25 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > This stores the avatar tokens in a config file, which can be reused in > KTp::Contact::avatar() - if we don't have avatar available from Tp, we check > the config file and see if we have cached token. This will be another patch. > > I think this will have problems with Gtalk's contact ids like > [email protected] - I'm not sure if these are > auto-generated from some key or what, but if each connection generates new > id, then this will be quite useless. > > EDIT: I missed the telepathy-module.cpp in the diff where it adds the > AvatarToken feature. > > > This addresses bug 315939. > http://bugs.kde.org/show_bug.cgi?id=315939 > > > Diffs > ----- > > contactnotify.h 9018114 > contactnotify.cpp ad82a73 > telepathy-module.cpp 1c986b1 > > Diff: http://git.reviewboard.kde.org/r/109432/diff/ > > > Testing > ------- > > Config file properly stored. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
