----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109403/#review29206 -----------------------------------------------------------
This review has been submitted with commit 71c92b36407a1d66c19e066b0f0c7b7fef89615c by David Edmundson to branch master. - Commit Hook On March 13, 2013, 5:33 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109403/ > ----------------------------------------------------------- > > (Updated March 13, 2013, 5:33 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Add a new class for processing outgoing messages > > Currently we re-use KTp::Message when the filters process a message to be > sent, this exposes a lot of setters and getters that have no use at all. > It also mixes HTML and plain text which has already led to one bug, and would > probably lead to more. > > This keeps the API cleaner and simpler > > -- > > This is an API and ABI break in the middle of a feature freeze, which is > normally against the results. > I want this patch in because I want the API to be sensible for people to > start writing their own plugins, I don't want them to break them for 0.7 > > > Diffs > ----- > > CMakeLists.txt 323afb3c965f28eeea84f51956b7aa55a7b5588e > KTp/CMakeLists.txt 448425593b6b1c2f0191c03e54871b7f7bc87ff5 > KTp/abstract-message-filter.h cf26907c5849b4df4ad725b2a5f7cb9f73953866 > KTp/abstract-message-filter.cpp 06d805db1e9e440ae95cdd0368c8ba3212c2bc4e > KTp/message-processor.h a22fc707a22f9171728d859387d21eff99afdbe2 > KTp/message-processor.cpp 2e252f9e81b622c5673f0037cd127f3381a337b4 > KTp/outgoing-message.h PRE-CREATION > KTp/outgoing-message.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109403/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
