> On March 18, 2013, 8:09 a.m., Martin Gräßlin wrote: > > I don't understand why you go so low-level. There must be some wrapper in > > either Qt or KWindowSystem > > David Edmundson wrote: > grep would imply otherwise. > > Qt takes it from the application name, but I don't think it's safe to > change that without side effects. > > > note that this code is practically taken from PlasmaApp which also does > this.
oh well, just checked the KDElibs code and seems you are right that there is no wrapper. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109560/#review29420 ----------------------------------------------------------- On March 18, 2013, 4:01 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109560/ > ----------------------------------------------------------- > > (Updated March 18, 2013, 4:01 a.m.) > > > Review request for Telepathy and Martin Gräßlin. > > > Description > ------- > > Provide a static method to set WmClass > > This allows us to group all KTp windows together > > See https://bugs.kde.org/show_bug.cgi?id=298470 > > > After using it, I'm not 100% sure I want the change. Lets keep all > discussion on that on bugzilla. > > CC'ing Martin G because it involves X and he really likes X. > > > Diffs > ----- > > KTp/CMakeLists.txt def690d62d0bbba56acf318a73a193bbc2f45994 > KTp/telepathy-handler-application.h > 4f8a059cdcb54bffcc12e179151bf190ef170fc2 > KTp/telepathy-handler-application.cpp > 8056dd1b55a1c74dfbb4dfa7357887a0afb54f9d > > Diff: http://git.reviewboard.kde.org/r/109560/diff/ > > > Testing > ------- > > Added corresponding line to both the contact list and text-ui. > > Both windows showed when I pressed cntrl+F7 also both share the same icon in > the task manager. > TBH, I'm not sure I like the behaviour. > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
