----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109556/#review29456 -----------------------------------------------------------
Note (to Martin) this is not really the same as the other removal of PendingOperation notificaitons. This is perfectly well allowed to fail if it cannot get ContactInfo, so will happen on pretty much every non Jabber account. - David Edmundson On March 18, 2013, 1:47 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109556/ > ----------------------------------------------------------- > > (Updated March 18, 2013, 1:47 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Remove KMessageWidget from ContactInfoDialog > > It is perfectly valid for upgradeContact() to fail if FeatureInfo is missing > Also we should NEVER show Tp::PendingOperation error messages to the user > > > Additional comment, this file should be in widgets, should I move it? > > > Diffs > ----- > > KTp/contact-info-dialog.cpp 17ad58390ec356beb04925d2899c3be83b8cf038 > > Diff: http://git.reviewboard.kde.org/r/109556/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
