> On March 20, 2013, 12:44 a.m., Dan Vrátil wrote: > > filters/images/images-filter.cpp, line 66 > > <http://git.reviewboard.kde.org/r/109596/diff/1/?file=120416#file120416line66> > > > > This is case-sensitive, so images with ".jpg" or ".JpG" filename > > extensions won't work. > > > > David Edmundson wrote: > there's a .toLower() the line above.
Ooops, sorry. (And for the record, QImageReader::supportedImageFormats() returns both lower- and upper-case strings) - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109596/#review29518 ----------------------------------------------------------- On March 20, 2013, 12:31 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109596/ > ----------------------------------------------------------- > > (Updated March 20, 2013, 12:31 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Simplify extension matching in image filtering > > This also fixes a bug in which the filter would match > urls that features .jpg or .png at any point in the filename not just at the > end > > > Diffs > ----- > > filters/images/images-filter.cpp 1036d5bc051d110bc2916a574da374913e821057 > > Diff: http://git.reviewboard.kde.org/r/109596/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
