----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109599/#review29604 -----------------------------------------------------------
Ship it! Ok, I know I'm annoying and probably paranoid... But I see race conditions everywhere! presence/src/presence-applet.cpp <http://git.reviewboard.kde.org/r/109599/#comment22082> I wonder if there is the possibility that you call NameHasOwner that is going to return false, but before the slot is activated, the contact list registers on dbus and the service watcher calls its slot. So the watcher slot sets it to true, but immediately after the NameHasOwner sets it to false, and therefore the toggleWindowVisibility will not be called until you close the contact list. Anyway even if it is possible (and probably it is not) it's not a big issue, so ship it until someone reports a bug on this :P - Daniele E. Domenichelli On March 20, 2013, 3:43 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109599/ > ----------------------------------------------------------- > > (Updated March 20, 2013, 3:43 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > This extends Dan's patch with a method in contact list, which will be part > 2/2. > > > Diffs > ----- > > presence/src/presence-applet.h f4889d6 > presence/src/presence-applet.cpp 58b6737 > > Diff: http://git.reviewboard.kde.org/r/109599/diff/ > > > Testing > ------- > > Works. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
