----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109652/#review29687 -----------------------------------------------------------
Ship it! KTp/Models/contacts-model.h <http://git.reviewboard.kde.org/r/109652/#comment22118> You should add some more documentation to this class, and to ContactsFilterModel. Perhaps an example of usage here, and a comment that for normal usage, this class should be used in ContactsFilterModel - Daniele E. Domenichelli On March 22, 2013, 9:17 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109652/ > ----------------------------------------------------------- > > (Updated March 22, 2013, 9:17 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Make setSourceModel in ContactsModel protected. > > This stops people using ContactsModel wrong. > > > Diffs > ----- > > KTp/Models/contacts-model.h 4d626d3aa103a1bd5397b0924907d4e37402c8d6 > KTp/Models/contacts-model.cpp 1c68409baf0e165b85e7611cf026e45e77ee86b4 > > Diff: http://git.reviewboard.kde.org/r/109652/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
