> On March 22, 2013, 8:20 a.m., David Edmundson wrote: > > KTp/Declarative/qml-plugins.cpp, line 52 > > <http://git.reviewboard.kde.org/r/109650/diff/1/?file=120947#file120947line52> > > > > We can kill this now
This exposes the properties in ContactsFilterModel and we probably still want them. I don't think qmlRegisterUncreatableType register parent classes. > On March 22, 2013, 8:20 a.m., David Edmundson wrote: > > KTp/Declarative/contact-list.h, line 51 > > <http://git.reviewboard.kde.org/r/109650/diff/1/?file=120945#file120945line51> > > > > This is not needed Well, not needed but what's the point in not changing that? > On March 22, 2013, 8:20 a.m., David Edmundson wrote: > > KTp/Declarative/contact-list.cpp, line 40 > > <http://git.reviewboard.kde.org/r/109650/diff/1/?file=120946#file120946line40> > > > > you do not need to, and should not call setSourceModel on the > > ContactsModel, it contains the ContactListModel internally > > > > I should probably make it protected in the API. It was there already before... - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109650/#review29674 ----------------------------------------------------------- On March 22, 2013, 1:42 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109650/ > ----------------------------------------------------------- > > (Updated March 22, 2013, 1:42 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > A suggested by David, use KTp::ContactsModel instead of > KTp::ContactsFilterModel. > > > Diffs > ----- > > KTp/Declarative/contact-list.h a598144 > KTp/Declarative/contact-list.cpp 18b1332 > KTp/Declarative/qml-plugins.cpp e754b25 > > Diff: http://git.reviewboard.kde.org/r/109650/diff/ > > > Testing > ------- > > I ran this, and it still lists contacts, so I have no idea why it doesn't > work. Maybe it's just too late... Ideas? > > import QtQuick 1.1 > import org.kde.plasma.core 0.1 as PlasmaCore > import org.kde.plasma.components 0.1 as PlasmaComponents > import org.kde.plasma.extras 0.1 as PlasmaExtras > import org.kde.telepathy 0.1 as KTp > > ListView { > KTp.ContactList { > id: groups > Component.onCompleted: { > model.groupMode = KTp.ContactsModel.GroupGrouping > } > } > height: 100 > width: 200 > model: groups.model > delegate: PlasmaComponents.ListItem { > width: parent.width > height: 20 > PlasmaComponents.Label { text: display } > } > } > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
