> On March 24, 2013, 11:37 a.m., Daniele E. Domenichelli wrote: > > Did you test this? Do tests still pass? Do all the plugin still work? > > If yes, then ship it, but push both parts at the same time please...
Tests got removed. Everything seems to still. It did \ escaping at the end anyway, so this "shouldn't" make a difference. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109685/#review29788 ----------------------------------------------------------- On March 24, 2013, 1:13 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109685/ > ----------------------------------------------------------- > > (Updated March 24, 2013, 1:13 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Move \ escaping into AdiumThemeView where it belongs > > BUG: 316267 > > This fixes the extra \\ appearing in notifications and in chat plasmoid. > Patch is part 1/2. We also need to remove BackslashFilter from common > internals.. which is pretty straightforward. > > > Diffs > ----- > > lib/adium-theme-view.cpp 9d1888f8561dc4193ef39f089989fc46b98ebef3 > > Diff: http://git.reviewboard.kde.org/r/109685/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
