----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109805/#review30169 -----------------------------------------------------------
Ship it! I don't understand how it worked before :S chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml <http://git.reviewboard.kde.org/r/109805/#comment22485> Is int better than variant? I don't know. Go with whichever you prefer. chat/org.kde.ktp-chat/contents/ui/main.qml <http://git.reviewboard.kde.org/r/109805/#comment22484> add a space so the ? are consistent - David Edmundson On March 30, 2013, 7:45 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109805/ > ----------------------------------------------------------- > > (Updated March 30, 2013, 7:45 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Right now the approximation to decide where to put the popup was very rough. > This didn't work that well with panels, especially the ones we were not > controlling especifically (Top and Right). This patch addresses that by > taking all them in account > > > Diffs > ----- > > chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml 8a854b3 > chat/org.kde.ktp-chat/contents/ui/main.qml 834ecaa > > Diff: http://git.reviewboard.kde.org/r/109805/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
