> On March 31, 2013, 5:27 p.m., David Edmundson wrote: > > In your opinion is it worth me pushing this into 0.6.0? (We've not tagged > > yet)
Hmm, how about this: I commit it to master so more people can test for races, and after some time (how long till tagging, there are 2 bugs for 0.6 left) we may pick it for 0.6 too. - Dominik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109807/#review30177 ----------------------------------------------------------- On March 31, 2013, 4:50 p.m., Dominik Cermak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109807/ > ----------------------------------------------------------- > > (Updated March 31, 2013, 4:50 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Stop using mission-controls ConnectAutomatically for autoconnect, instead use > our kded-module only. > > The diff looks worse than it is. Most of the old code has been deleted, one > new method has been added, but the unified diff mixes this all... > > > This addresses bug 307175. > http://bugs.kde.org/show_bug.cgi?id=307175 > > > Diffs > ----- > > autoconnect.h e296012586a67aed88a87e2c166ff526ab0fa76d > autoconnect.cpp 526b060db162e81accb6da0d1d81cb6dd22c43c0 > telepathy-module.cpp a28bca86f03e971ec7d68b62d69c8802d1b05677 > > Diff: http://git.reviewboard.kde.org/r/109807/diff/ > > > Testing > ------- > > Still testing if race conditions occur (auth-handler/kwallet timeout). So far > no problems. > > > Thanks, > > Dominik Cermak > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
