----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110016/#review31136 -----------------------------------------------------------
Ship it! Looks good to me, I'm just not sure about the BC break as the lib takes the soversion from the main lib while it should be bumped for the declarative lib KTp/Declarative/messages-model.cpp <http://git.reviewboard.kde.org/r/110016/#comment23147> The worst copy-paste job ever - Martin Klapetek On April 14, 2013, 9:55 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110016/ > ----------------------------------------------------------- > > (Updated April 14, 2013, 9:55 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Expose senderId, senderAlias and senderAvatar properties in MessageModel > > Also remove rather ambiguous UserRole which used to have sender alias > > This does break the declarative API, but not the main lib. > > > Diffs > ----- > > KTp/Declarative/messages-model.h 83d879265a966740beee577560d57384b8eec83c > KTp/Declarative/messages-model.cpp 2c15c276534b1cb0d869e17f6124261c6ccf05dd > > Diff: http://git.reviewboard.kde.org/r/110016/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
