----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110120/#review31398 -----------------------------------------------------------
Ship it! contactlist/org.kde.ktp-contactlist/contents/ui/ListContactDelegate.qml <http://git.reviewboard.kde.org/r/110120/#comment23417> That's a bit odd... I think that hardcoding the chat plasmoid here means that there are some users who'll want windows and others who'll want plasma. I think we should find a solution where the chats will appear in the meaningful place. I'd say that a user will expect chats to appear the same way from both contact lists. Looks good, definitely an improvement! - Aleix Pol Gonzalez On April 21, 2013, 10 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110120/ > ----------------------------------------------------------- > > (Updated April 21, 2013, 10 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Port Chat applet to new declarative API > > > Port contact list applet to new API > > > Diffs > ----- > > contactlist/org.kde.ktp-contactlist/contents/ui/main.qml > 89a926267abe14ef7e0343ef83df0c0de0d7916e > contactlist/org.kde.ktp-contactlist/contents/ui/ListContactDelegate.qml > aec65b366098553c3612a6822eb2de9f013a434f > contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml > 307563c8f99c73720602046562f4a78914e490fe > chat/org.kde.ktp-chat/contents/ui/main.qml > 0f18b8b579b5ce72109b58df9fc808ec6763a164 > chat/org.kde.ktp-chat/contents/ui/ConversationDelegateButton.qml > 68017c2492e738901198238e5e206379b561a49a > > Diff: http://git.reviewboard.kde.org/r/110120/diff/ > > > Testing > ------- > > Started a chat from the contact list applet (it now appears in the chat > plasmoid if it's running, text-ui otherwise) > > Chat plasmoid works as before > Tested removing the chat plasmoid removed the client registrar. Everything > all works perfectly. > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
