-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105521/
-----------------------------------------------------------
(Updated April 23, 2013, 6:46 p.m.)
Status
------
This change has been discarded.
Review request for Telepathy.
Description
-------
This fixes the annoying bug stopping the plasmoid from scrolling properly as
elegantly as possible.
The problems is that because delegates are created on demand, there's no way
for the ListView to determine the height of all its content. It currently just
takes the size of one delegate, and multiplies it by the amount of items in the
model. While that works in scenarios where the delegates are all the same
height, it does not here.
What this does is -abuse- use the cacheBuffer property to force it to keep all
delegates in ram. While it uses more memory, it let's us work around this issue
(Only other option is to remove the scrollbar).
PS: I tried to set the cacheBuffer to view.count, but that made it ignore it
completely (I think it can't change after initialized for it to be taken
seriously).
This addresses bug 293522.
http://bugs.kde.org/show_bug.cgi?id=293522
Diffs
-----
plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 90cc07d
plasmoid/org.kde.ktp-chatplasmoid/contents/ui/OutgoingDelegate.qml d713958
tests/message-processor-basic-tests.h 35f931f
tests/message-processor-basic-tests.cpp 554ce1a
Diff: http://git.reviewboard.kde.org/r/105521/diff/
Testing
-------
Talked to myself.
Thanks,
Lasath Fernando
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
