> On April 29, 2013, 9:21 a.m., Martin Klapetek wrote: > > global-presence-chooser.cpp, line 371 > > <http://git.reviewboard.kde.org/r/110227/diff/2/?file=141323#file141323line371> > > > > One more coding style nitpick -- if( index ... Index ) --> if > > (index...Index) ;)
That is the most confusing place to put a smiley face at the end of a sentence ;) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110227/#review31737 ----------------------------------------------------------- On April 29, 2013, 2:33 a.m., Ian Monroe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110227/ > ----------------------------------------------------------- > > (Updated April 29, 2013, 2:33 a.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Description > ------- > > Now playing shouldn't be disabled on pause > > Fix requires corresponding commit in ktp-kded-module > https://git.reviewboard.kde.org/r/110228/ > Needed to separate things done for every presence change > from those actions only to be done on user-initiated presence changes > > > Diffs > ----- > > global-presence-chooser.h 678681c92afcbfcc85245b809bd29e84477eacfa > global-presence-chooser.cpp f5d59399a904195121ebac7266bef4176ac82bfb > presence-model.h 2ce652ffe50197e652e99f7190b3a988f87cb4e3 > > Diff: http://git.reviewboard.kde.org/r/110227/diff/ > > > Testing > ------- > > > Thanks, > > Ian Monroe > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
